Revert "Add fill attribute to pointer-up and pointer-down icons" #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea267fe.
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Jun 24, 2024
This fixes a regression in the appearance of the adder toolbar. See hypothesis/frontend-shared#1594.
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Jun 24, 2024
This fixes a regression in the appearance of the adder toolbar. See hypothesis/frontend-shared#1594.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1586.
This broke rendering of the adder toolbar in the client. It turns out the
fillattribute was intentionally omitted for this particular icon, with the idea being that the caller can set it on a parent DOM element and have it inherited.Before:
After:
Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1719230027843259