Update to Angular 1.6.9 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change that affects us is that component inputs/bindings are no longer available as controller properties in the constructor by default. Instead this logic should go in a controller's `$onInit` method. In this commit use the `$compileProvider.preAssignBindingsEnabled` compatibility helper which preserves the Angular <= 1.5 behavior. This is being removed in Angular 1.7.
Fix occurrences of a "multilink" [1] error during test for the annotation save button. Replace calls to the link function with direct assignments to controller properties. [1] https://code.angularjs.org/1.6.9/docs/error/$compile/multilink
Fix a test failure due to a subtle issue with the interaction between the `$q` service, `AnnotationController#delete` and `$timeout.flush` in tests. Instantiating the rejected promise _before_ calling `$timeout.flush` resulted in Angular's unhandled promise checking code being triggered in the test.
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 91.03% 91.05% +0.01%
==========================================
Files 135 135
Lines 5397 5397
Branches 934 934
==========================================
+ Hits 4913 4914 +1
+ Misses 484 483 -1
Continue to review full report at Codecov.
|
|
It's hard to test everything and know for sure that a framework update like this didn't break anything, but on a brief look I couldn't find any problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the current stable version of Angular (1.5.6 => 1.6.9). The full changelog has all the details including breaking changes since 1.5.x.
The main backwards incompatible change which affects us is that by default component inputs are no longer available in controller constructors but only during/after the
$onInitmethod is called [1]. There is apreAssignBindingsEnabledbackwards compatibility helper which preserves the previous behaviour. I have enabled this in both the sidebar application and tests for components which need it.See commit messages for details on other fixes required.
[1] Controllers in Angular are effectively classes and this change was introduced to make it possible to use ES6 classes as components, plus it has the benefit of encouraging the init code for a component to be put in one obvious place.