Embed release version in built package #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Looks like the It also looks like maybe |
Rather than relying on the release version being passed in as config,
build the current release version (as read from `package.json`) into the
bundle.
We use browserify-versionify for this, rather than simply requiring
`package.json`, as our current build toolchain does not support any kind
of tree-shaking, so `require('package.json')` would pull the whole of
the `package.json` file into the bundle.
f0206c6 to
af954a8
Compare
|
Okay, that's fixed. Also a "get everything to some kind of stable state" PR now open at #66. |
FWIW there is a Browserify transform for that: https://github.com/nolanlawson/package-json-versionify |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than relying on the release version being passed in as config, build the current release version (as read from
package.json) into the bundle.We use browserify-versionify for this, rather than simply requiring
package.json, as our current build toolchain does not support any kind of tree-shaking, sorequire('package.json')would pull the whole of thepackage.jsonfile into the bundle.