Rename JS bundles to match corresponding source directory #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 135 135
Lines 5367 5367
Branches 930 930
=======================================
Hits 4883 4883
Misses 484 484
Continue to review full report at Codecov.
|
robertknight
added a commit
that referenced
this pull request
Dec 11, 2017
Rename the entry point for the annotator CSS bundle so that it matches the name of the source directory from which the bundle is compiled and also the name of the corresponding JS bundle once that is renamed by #633
2e3c3fb to
c555ddc
Compare
0cf0ce0 to
7c0567d
Compare
|
Rebased |
Rename the "injector" and "app" bundles to "annotator" and "sidebar" respectively to match the source directory which produces those bundles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs to address some low hanging fruit to hopefully make it easier for newcomers to find their way around the client code.
Rename the "injector" and "app" bundles to "annotator" and "sidebar"
respectively to match the source directory which produces those bundles.