Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show share dialog if no incontext link #618

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Dec 1, 2017

If the annotation received from the API contains no incontext link (as is the case with third-party annotations, for example) then don't render the annotation share dialog that contains the incontext link.

This is one half of the fix for #613, the other half is hypothesis/h#4714.

If the annotation received from the API contains no incontext link (as
is the case with third-party annotations, for example) then don't render
the annotation share dialog that contains the incontext link.
@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #618 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   90.91%   90.95%   +0.03%     
==========================================
  Files         133      134       +1     
  Lines        5351     5374      +23     
  Branches      931      935       +4     
==========================================
+ Hits         4865     4888      +23     
  Misses        486      486
Impacted Files Coverage Δ
src/sidebar/components/login-control.js 100% <0%> (ø) ⬆️
src/sidebar/filter/persona.js 100% <0%> (ø)
src/sidebar/components/annotation.js 88.73% <0%> (+0.05%) ⬆️
src/sidebar/components/hypothesis-app.js 90.36% <0%> (+0.11%) ⬆️
src/sidebar/components/group-list.js 95.65% <0%> (+0.19%) ⬆️
src/sidebar/components/annotation-header.js 88.23% <0%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dc774...0cf1ccb. Read the comment docs.

@robertknight
Copy link
Member

LGTM. Tested by removing both the "html" and "incontext" link generators in h/links.py in the "h" service.

@robertknight robertknight merged commit 30cdd97 into master Dec 1, 2017
@robertknight robertknight deleted the dont-show-bouncer-links-when-no-bouncer-url branch December 1, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants