Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphans tab feature flag checks #578

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Conversation

robertknight
Copy link
Member

This PR removes a set of obsolete code paths for supporting the case where the "Orphans" tab was disabled. After this is merged, we can remove the "orphans_tab" feature flag from the service.

There is no time pressure on this one, but I've had it sitting around for a while locally and we should always be getting rid of code that no longer serves a purpose.

This has been enabled for all users for many months now.
This is now always set to true following the removal of the
`orphans_tab` feature flag checks.
@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #578 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   90.92%   90.92%   -0.01%     
==========================================
  Files         132      132              
  Lines        5347     5334      -13     
  Branches      928      926       -2     
==========================================
- Hits         4862     4850      -12     
+ Misses        485      484       -1
Impacted Files Coverage Δ
src/sidebar/components/annotation.js 88.94% <ø> (+0.3%) ⬆️
src/sidebar/components/selection-tabs.js 83.33% <ø> (-1.67%) ⬇️
src/sidebar/tabs.js 100% <100%> (ø) ⬆️
src/sidebar/components/sidebar-content.js 89.47% <100%> (-0.14%) ⬇️
src/sidebar/root-thread.js 98.48% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbad41...093ef18. Read the comment docs.

@seanh
Copy link
Contributor

seanh commented Nov 15, 2017

Agree, this is a lot of code removal and simplification, it's important to do. Works here and looks good to me

@seanh seanh merged commit 09e5414 into master Nov 15, 2017
@seanh seanh deleted the remove-orphans-tab-flag branch November 15, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants