Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth client registration steps to developer docs #567

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

robertknight
Copy link
Member

Add additional steps to the documentation for using a local build of the client with a local instance of "h". These steps will be mandatory once cookie auth is no longer supported.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         137      137           
  Lines        5451     5451           
  Branches      942      942           
=======================================
  Hits         4968     4968           
  Misses        483      483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b78d87...fedcd1c. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         137      137           
  Lines        5451     5451           
  Branches      942      942           
=======================================
  Hits         4968     4968           
  Misses        483      483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b78d87...16c8ee1. Read the comment docs.

@robertknight robertknight requested a review from seanh November 6, 2017 17:19
@seanh
Copy link
Contributor

seanh commented Nov 7, 2017

I added a note that you need to be logged in to h as an admin to access the oauthclients page

@seanh
Copy link
Contributor

seanh commented Nov 7, 2017

👍 easy to follow, worked here

@seanh seanh merged commit e587d79 into master Nov 7, 2017
@seanh seanh deleted the oauth-client-registration-docs branch November 7, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants