Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp tooltips in annotation cards #546

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

robertknight
Copy link
Member

Timestamps on annotation cards are supposed to display the full date and
time in the tooltip. This didn't work because ng-title is not a thing.

CC @judell

Timestamps on annotation cards are supposed to display the full date and
time in the tooltip. This didn't work because `ng-title` is not a thing.
@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #546 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         136      136           
  Lines        5432     5432           
  Branches      948      948           
=======================================
  Hits         4941     4941           
  Misses        491      491
Impacted Files Coverage Δ
src/sidebar/components/timestamp.js 95.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2544f6a...aab4e43. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #546 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         136      136           
  Lines        5432     5432           
  Branches      948      948           
=======================================
  Hits         4941     4941           
  Misses        491      491
Impacted Files Coverage Δ
src/sidebar/components/timestamp.js 95.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2544f6a...aab4e43. Read the comment docs.

@robertknight robertknight merged commit 5dcef08 into master Sep 20, 2017
@robertknight robertknight deleted the fix-timestamp-tooltip branch September 20, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants