Render display name in new annotations #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the display name is provided by the server in the annotation's `user_info` field, render it instead of the username in annotation card headers.
Populate the `user_info` field for new annotations from the logged-in user's profile. This enables new annotation cards to render the user's display name instead of their username if they have set one. This logic is currently in the annotation component init function for consistency with how the `user` field is initialized. However, it really ought to be in the code that handles the `addAnnotations` Redux action.
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 90.93% 90.96% +0.02%
==========================================
Files 136 136
Lines 5428 5432 +4
Branches 946 948 +2
==========================================
+ Hits 4936 4941 +5
+ Misses 492 491 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #541
Initialize the
user_infofield for new annotationsPopulate the
user_infofield for new annotations from the logged-inuser's profile. This enables new annotation cards to render the user's
display name instead of their username if they have set one.
This logic is currently in the annotation component init function for
consistency with how the
userfield is initialized. However, it reallyought to be in the code that handles the
addAnnotationsRedux action.