Use vendor-prefixed msCrypto property for IE 11
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with [1] this fixes the OAuth popup failing to appear when clicking "Log in" in IE 11. [1] #537
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 90.93% 90.93% +<.01%
==========================================
Files 136 136
Lines 5428 5429 +1
Branches 945 946 +1
==========================================
+ Hits 4936 4937 +1
Misses 492 492
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 90.93% 90.93% +<.01%
==========================================
Files 136 136
Lines 5428 5429 +1
Branches 945 946 +1
==========================================
+ Hits 4936 4937 +1
Misses 492 492
Continue to review full report at Codecov.
|
|
I'm just going to trust you on this one. Once OAuth login in IE11 is working end-to-end I can test that PR in an IE VM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with [1] this fixes the OAuth popup failing to appear when
clicking "Log in" in IE 11.
The OAuth login flow still doesn't actually work in IE 11 with these two PRs because of issues with cross-domain
window.postMessage. However, it does fix part of the problem.[1] #537