Fix decoding of the query section in "#annotations" fragments. #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `decodeURIComponent` instead of `decodeURI` because `decodeURIComponent` decodes reserved characters (eg. ":", "/") whereas `decodeURI` does not. Avoid stubbing decodeURIComponent() in the tests and instead just use a malformed escape sequence which triggers an actual URIError when decoding.
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.03%
==========================================
Files 133 134 +1
Lines 5151 5305 +154
Branches 881 914 +33
==========================================
+ Hits 4628 4768 +140
- Misses 523 537 +14
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
decodeURIComponentinstead ofdecodeURIbecausedecodeURIComponentdecodes reserved characters (eg. ":", "/") whereasdecodeURIdoes not.Avoid stubbing
decodeURIComponentin the tests and instead just use amalformed escape sequence which triggers an actual URIError when
decoding.