Fix view switcher flash on iOS #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view switcher tabs at the top of the sidebar would flash grey for a moment after you clicked one. This removes the flash. This webkit "tap highlight" is actually an iOS Safari usability feature, it indicates to the user that their tap is being successfully recognized, and indicates which element they're tapping on. But I don't think it looks good with these tabs of ours, and it seems to interact badly with the background colour animated transition we're using (it seems to do the animated transition first and _then_ flash the tap highlight colour for a second). We're providing this indication by changing the colour of the tab anyway, so disable it.
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 133 133
Lines 5151 5151
Branches 881 881
=======================================
Hits 4628 4628
Misses 523 523Continue to review full report at Codecov.
|
|
LGTM. |
seanh
added a commit
that referenced
this pull request
Jul 31, 2017
Remove the (feature-flagged) view switcher component. We missed the chance to strike while the iron was hot on this one - neither Dawa or I have time anymore to work on further design iterations. I don't want to have dead code living behind a feature flag so I'm removing it. The code will still be in git if we ever want to revive it. Perhaps these tabs can be re-designed as part of a larger re-design of the sidebar in the future. I'll leave the GitHub issue about the usability issues with the existing selection tabs open: hypothesis/product-backlog#327 For the record the main remaining issues with this were: 1. An undesirable visual popping happens when the view switcher loads on pages that have a lot of annotations. This also happens with the existing selection tabs but is arguably more visible with the view switcher. 2. When there are only two tabs (no orphans) the visual design of the tabs doesn't make it as immediately obvious which is the currently selected tab. The other tab may be mistaken for the selected one. The TODO list was here: hypothesis/product-backlog#327 (comment) The pull requests for this view switcher were: #429 #481 #482 hypothesis/product-backlog#327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view switcher tabs at the top of the sidebar would flash grey for a
moment after you clicked one. This removes the flash.
This webkit "tap highlight" is actually an iOS Safari usability feature,
it indicates to the user that their tap is being successfully recognized, and
indicates which element they're tapping on. But I don't think it looks
good with these tabs of ours, and it seems to interact badly with the
background colour animated transition we're using (it seems to do the
animated transition first and then flash the tap highlight colour for
a second).
We're providing this indication by changing the colour of the tab
anyway, so disable it.