Fix sidebar app failing to load in Firefox extension. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular has a check for Chrome Packaged Apps in its `$sniffer` service which changes the behavior of the $location service and in the Firefox extension, triggers a redirect from `/client/app.html` to `/#client/app.html` on startup, breaking the sidebar app. This commit works around the problem by adding a fake `window.chrome.app` object to convince Angular that the Firefox extension is not a Chrome Packaged App. Issue reported upstream at angular/angular.js#16068
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 127 127
Lines 5036 5036
Branches 865 865
=======================================
Hits 4526 4526
Misses 510 510Continue to review full report at Codecov.
|
|
I was able to reproduce the bug and Firefox, see comment on corresponding browser extension PR: hypothesis/browser-extension#41 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a regression with the Firefox extension yesterday which makes it no longer usable. There are a couple of problems in the extension itself, but the main issue is that the sidebar app does not load properly, which is fixed by this hack.
Angular has a check for Chrome Packaged Apps in its
$snifferservicewhich changes the behavior of the $location service and in the Firefox
extension, triggers a redirect from
/client/app.htmlto/#client/app.htmlon startup, breaking the sidebar app.This commit works around the problem by adding a fake
window.chrome.appobject to convince Angular that the Firefoxextension is not a Chrome Packaged App.
Issue reported upstream at angular/angular.js#16068