Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "host" service #446

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Remove unused "host" service #446

merged 2 commits into from
Jun 19, 2017

Conversation

robertknight
Copy link
Member

As far as I can ascertain, this Angular service isn't used any more. There are no calls to its exported API (host.showSidebar, host.hideSidebar).

I'm currently checking whether there is any code in src/annotator that is also no longer used as a result.

@codecov-io
Copy link

codecov-io commented Jun 14, 2017

Codecov Report

Merging #446 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   89.85%   89.82%   -0.03%     
==========================================
  Files         128      127       -1     
  Lines        5025     5014      -11     
  Branches      860      861       +1     
==========================================
- Hits         4515     4504      -11     
  Misses        510      510
Impacted Files Coverage Δ
src/annotator/sidebar.coffee 81.25% <ø> (-0.39%) ⬇️
src/shared/polyfills.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f96510...ab7f40d. Read the comment docs.

These events are never emitted by other code.
@robertknight
Copy link
Member Author

I think I'm satisfied that the bridge events this code used to listen for are not emitted anywhere and the event listeners for the events that this module used to send to the host frame are no longer used either.

@robertknight robertknight removed the WIP label Jun 14, 2017
@seanh seanh self-assigned this Jun 19, 2017
@seanh
Copy link
Contributor

seanh commented Jun 19, 2017

Good find

@seanh seanh merged commit e1388ab into master Jun 19, 2017
@seanh seanh deleted the remove-host-svc branch June 19, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants