Don't throw if hypothesisConfig() isn't a function #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log a warning, rather than throwing an error, if window.hypothesisConfig() exists but isn't a function. "Warn but continue" is in line with our general approach to handling invalid configuration in the client. For example if there's an invalid js-hypothesis-config script in the page it logs a warning and continues. For some required config settings, such as config.app, if the setting is invalid then the client crashes out immediately because it can't continue. But otherwise it should warn and continue.
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 89.72% 89.72% +<.01%
==========================================
Files 124 124
Lines 4955 4956 +1
Branches 855 855
==========================================
+ Hits 4446 4447 +1
Misses 509 509
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a warning, rather than throwing an error, if
window.hypothesisConfig() exists but isn't a function.
"Warn but continue" is in line with our general approach to handling
invalid configuration in the client. For example if there's an invalid
js-hypothesis-config script in the page it logs a warning and continues.
For some required config settings, such as config.app, if the setting is
invalid then the client crashes out immediately because it can't
continue. But otherwise it should warn and continue.