Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding console log capture to karma #420

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Conversation

sean-roberts
Copy link
Contributor

This hasn't been an issue for me until lately. But this is a reinforcement that console.logs in karma tests should mirror back to the terminal output

@codecov-io
Copy link

codecov-io commented Jun 5, 2017

Codecov Report

Merging #420 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage    89.7%   89.75%   +0.05%     
==========================================
  Files         123      123              
  Lines        4924     4969      +45     
  Branches      850      863      +13     
==========================================
+ Hits         4417     4460      +43     
- Misses        507      509       +2
Impacted Files Coverage Δ
src/sidebar/analytics.js 100% <0%> (ø) ⬆️
src/annotator/config.js 100% <0%> (ø) ⬆️
src/sidebar/components/group-list.js 96% <0%> (+0.34%) ⬆️
src/annotator/adder.js 89.43% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4d883...7bf4122. Read the comment docs.

@robertknight
Copy link
Member

In the Travis build output at https://travis-ci.org/hypothesis/client/jobs/239675821 I see a spurious message about trying to load Angular multiple times. Can we find a way to suppress that?

Otherwise LGTM.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but see note about spurious message re. loading Angular multiple times which I'd like to quash if possible.

@sean-roberts sean-roberts merged commit a133df5 into master Jun 6, 2017
@chdorner chdorner deleted the karma-conf-update branch September 22, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants