Update flag count after moderator flags an annotation themselves #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule Tests for actions should live in the test module associated with the module that defines the actions.
Flagging or unflagging an annotation previously updated the status flag indicating whether an annotation had been flagged by the current user but did not update the flag count if the user was also a moderator. This needs to be done to make the moderation banner's state update when a user who is also a moderator flags an annotation.
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
+ Coverage 76.57% 76.6% +0.02%
=========================================
Files 119 119
Lines 5952 5958 +6
Branches 968 971 +3
=========================================
+ Hits 4558 4564 +6
Misses 1394 1394
Continue to review full report at Codecov.
|
e1106db to
fe50275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user who is also a moderator flags an annotation, the client updated the
flaggedkey in its local copy of the annotation but not themoderation.flag_countkey (if present), so the moderation banner did not reflect the change in flag status.In the scenario where an unflagged annotation is flagged by a moderator, this meant that the moderation banner did not appear and the user had to reload the page to actually hide the annotation.
Fixes #346