Work around getComputedStyle bug in Firefox
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<thread-list>` uses `getComputedStyle` to find the nearest scrollable ancestor element which it needs to know in order to scroll specific annotations into view and determine which annotations are visible. In Firefox `getComputedStyle` may return `null` if the iframe is hidden - which may be the case when this code is called in the sidebar. This is considered a bug upstream. Work around it in the meantime by adding a specific class (`js-scrollable`) to the scrollable element and testing for that as a fallback. Fixes #341
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 76.55% 76.51% -0.05%
==========================================
Files 120 120
Lines 5946 5940 -6
Branches 964 964
==========================================
- Hits 4552 4545 -7
- Misses 1394 1395 +1
Continue to review full report at Codecov.
|
Currently the app only ever has one `<thread-list>` instance, so we can simplify the logic that gets the scroll root to just query for a hard-coded selector.
This could return `null` in Firefox when the sidebar iframe is hidden.
|
Works for me, and I think the new code is better as well (I'm not sure I understand the future use case that finding the nearest scrollable element was trying to support) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<thread-list>usesgetComputedStyleto find the nearest scrollableancestor element which it needs to know in order to scroll specific
annotations into view and determine which annotations are visible.
In Firefox
getComputedStylemay returnnullif the iframe is hidden which may be the case when this code is called in the sidebar. This is considered a bug upstream. Work around it in the meantime by adding a specific class to the scrollable element and testing for thatas a fallbackinstead.Fixes #341