Fixing sidebar not closing on outside content click issue #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 76.6% 76.71% +0.11%
==========================================
Files 120 120
Lines 5886 5889 +3
Branches 959 960 +1
==========================================
+ Hits 4509 4518 +9
+ Misses 1377 1371 -6
Continue to review full report at Codecov.
|
| @@ -47,6 +47,16 @@ module.exports = class Sidebar extends Host | |||
| @element.on 'click', (event) => | |||
| if !@selectedTargets?.length | |||
| this.hide() | |||
|
|
|||
| # Mobile browsers do not register click events on | |||
There was a problem hiding this comment.
I thought that this restriction applied only to iOS but not to Android Chrome. This works either way.
robertknight
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
Since click is not registered for elements without
cursor: pointerwe will listen for the touchstart in addition to the click event so we can get around this issue for mobile devices.