Fix scrolling to new annotations #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #306 which set the height of the `<hypothesis-app>` container element to 100%, the height of `document.body` is now equal to the window's `innerHeight`. As a result, `document.body.clientHeight` now returns the same value as `window.innerHeight` and `scrollOffset()` returns 0. Fix this by using `scrollHeight` instead of `clientHeight`, which takes into account the height of all of the body's descendant elements, including the `<thread-list>`. This calculation would still return the wrong result if the `<thread-list>` were ever placed in a separate scrolling container within the sidebar app window, but that is an acceptible limitation for now.
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
======================================
Coverage 76.6% 76.6%
======================================
Files 120 120
Lines 5887 5887
Branches 959 959
======================================
Hits 4510 4510
Misses 1377 1377
Continue to review full report at Codecov.
|
|
I'm aware that this code would require some additional changes if we ever moved This PR also doesn't address the second issue I noted in #319 (comment) about when the scrolling happens, because the reason that it worked before still applies after this change. Fixing that properly will require some more meaty refactoring which should be done separately. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short version: Scrolling to new annotations which were off-screen failed because the function which computed the vertical offset to scroll the sidebar to when a new annotation was added always returned 0. This was due to using the wrong geometry property of
document.bodyto get the height of the content.The previous method happened to work prior to what should have been an innocent change in #306 which set the height of the
<hypothesis-app>element to the height of the viewport.Longer version: See #319 (comment)
Testing: Build a prod Chrome extension and follow the steps in #319
Fixes #319