Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile cursor from jumping to bottom #2625

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Fix mobile cursor from jumping to bottom #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3733897
Revise a comment about preventing selection inside the adder
robertknight Oct 12, 2020
796c74b
Enable mobile-optimized viewport in dev server home page
robertknight Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-server/templates/index.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html>
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Hypothesis Client Test</title>
<style>
body {
Expand Down
5 changes: 3 additions & 2 deletions src/styles/annotator/components/adder.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ $adder-transition-duration: 80ms;
background: var.$color-background;
border-radius: var.$annotator-border-radius;

// Prevent the adder from being highlighted during text selection.
// This caused an bug that appears on android devices during text selection.
// Prevent the browser from selecting text in the adder itself during text
// selection.
//
// See https://github.com/hypothesis/product-backlog/issues/878
user-select: none;

Expand Down