Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove account settings and logout link from login control for 3rd pa… #231

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

sheetaluk
Copy link
Contributor

…rty users.

For 3rd party users:
Remove the 'Account settings' link from the account menu
Remove the logout link from the account menu

Related PR:
#228

Fixes:
hypothesis/product-backlog#141

…rty users.

For 3rd party users:
Remove the 'Account settings' link from the account menu
Remove the logout link from the account menu

Related PR:
#228

Fixes:
hypothesis/product-backlog#141
@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #231   +/-   ##
======================================
  Coverage    75.3%   75.3%           
======================================
  Files         114     114           
  Lines        5733    5733           
  Branches      936     936           
======================================
  Hits         4317    4317           
  Misses       1416    1416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee4083...8fcf28f. Read the comment docs.

@robertknight
Copy link
Member

LGTM. We don't have any tests for login-control yet. Perhaps you could look into adding a few?

@robertknight robertknight merged commit b4c2349 into master Feb 17, 2017
@robertknight robertknight deleted the authority-group-tweaks branch February 17, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants