Use a custom element name for highlight spans #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same trick that was applied to the adder in d9644a8 to reduce the likelihood of the page's own CSS styling modifying the appearance of highlights. Compared to alternative methods which would raise the precedence of highlight styling (inline styles, !important !all !the !things, selector precedence hacks), this approach is simpler as it makes the conflicting rule from the page's own styling not apply at all. Fixes hypothesis/h#3520
|
we need to make sure good cross-browser testing is done with this as well. |
|
|
||
| # A custom element name is used here rather than `<span>` to reduce the | ||
| # likelihood of highlights being hidden by page styling. | ||
| hl = $("<hypothesis-highlight class='#{cssClass}'></hypothesis-highlight>") |
There was a problem hiding this comment.
It seems like the CSS class is a bit redundant now, so perhaps in future we could look into removing that.
|
Code LGTM. @robertknight if you confirm that you've tested this with our supported browsers, we'll merge it. In future, please chase PRs like this for a review so that they don't have to sit around for nearly a month. |
Yes. Tested with Chrome, Firefox, Edge, IE & Mobile Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same trick that was applied to the adder in
d9644a8 to reduce the likelihood of the
page's own CSS styling modifying the appearance of highlights.
Compared to alternative methods which raise the precedence of
highlight styling (inline styles, !important !all !the !things, selector
precedence hacks), this approach is simpler as it makes the conflicting
rule from the page's own styling not apply at all.
The "hypothesis-" prefix matches the prefix used for the adder's container.
Fixes hypothesis/h#3520