Only save pending updates for annotations in the focused group #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickstenning
suggested changes
Sep 16, 2016
There was a problem hiding this comment.
Unfortunately this change breaks the behaviour of deletes, which don't carry group information.
Previously, if you created and deleted an annotation in the current group on another page, the delete would clear the pending update. On this branch that no longer happens.
Probably worth adding a test for this scenario.
| // Ignore updates to annotations that are not in the focused group | ||
| return ann.group === groups.focused().id; | ||
| }); | ||
| annotationMapper.loadAnnotations(Object.values(pendingUpdates)); |
There was a problem hiding this comment.
It's a tiny tiny thing, but honestly this would be clearer if you stuck to the pattern you had before:
var updates = Object.values(pendingUpdates);
var deletions = ...;
annotationMapper.loadAnnotations(updates);
annotationMapper.unloadAnnotations(deletions);Since we discard all pending updates and deletions when switching groups, discard create/update notifications about annotations in unfocused groups as soon as we receive them. This fixes the issue where the 'Apply Update' badge counted updates from other groups, with the result that clicking the badge did not show any changes.
ddafd5d to
3dc467c
Compare
nickstenning
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we discard all pending updates and deletions when switching
groups, discard notifications about annotations in unfocused groups
as soon as we receive them.
This fixes the issue where the 'Apply Update' badge counted updates
from other groups, with the result that clicking the badge did not
show any changes.