Fix waiting for PDF to load

hypothesis · Oct 9, 2020 · 7d0f474 · 7d0f474
1 parent 150e15b
commit 7d0f474
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/annotator/anchoring/pdf.js b/src/annotator/anchoring/pdf.js
@@ -79,10 +79,10 @@ async function getPageView(pageIndex) {
     // a "pdfPage" property.
     pageView = await new Promise(resolve => {
       const onPagesLoaded = () => {
-        document.removeEventListener('pagesloaded', onPagesLoaded);
+        pdfViewer.eventBus.off('pagesloaded', onPagesLoaded);
         resolve(pdfViewer.getPageView(pageIndex));
       };
-      document.addEventListener('pagesloaded', onPagesLoaded);
+      pdfViewer.eventBus.on('pagesloaded', onPagesLoaded);
     });
   }
 

diff --git a/src/types/pdfjs.js b/src/types/pdfjs.js
@@ -62,6 +62,7 @@
  * Defined in `web/pdf_viewer.js` in the PDF.js source.
  *
  * @prop {number} pagesCount
+ * @prop {EventBus} eventBus - Reference to the global event bus
  * @prop {(page: number) => PDFPageView|null} getPageView
  */