Fix the "create a free account" link on the sidebar CTA

hypothesis · Jul 27, 2016 · 19281b7 · 19281b7
1 parent 9469c27
commit 19281b7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/h/static/scripts/app-controller.js b/h/static/scripts/app-controller.js
@@ -52,6 +52,8 @@ module.exports = function AppController(
   // the stream page or an individual annotation page.
   $scope.isSidebar = $window.top !== $window;
 
+  $scope.serviceUrl = settings.serviceUrl;
+
   $scope.sortKey = function () {
     return annotationUI.getState().sortKey;
   };

diff --git a/h/static/scripts/test/app-controller-test.js b/h/static/scripts/test/app-controller-test.js
@@ -95,6 +95,7 @@ describe('AppController', function () {
 
     fakeSettings = {
       firstRun: false,
+      serviceUrl: 'http://fake.service.com/',
     };
 
     $provide.value('annotationUI', fakeAnnotationUI);
@@ -185,6 +186,11 @@ describe('AppController', function () {
     });
   });
 
+  it('exposes the serviceUrl on the scope', function () {
+    createController();
+    assert.equal($scope.serviceUrl, 'http://fake.service.com/');
+  });
+
   it('does not show login form for logged in users', function () {
     createController();
     assert.isFalse($scope.accountDialog.visible);

diff --git a/h/templates/client/app.html b/h/templates/client/app.html
@@ -13,7 +13,7 @@
 
 <div class="create-account-banner" ng-if="isSidebar && auth.status === 'logged-out'" ng-cloak>
   To annotate this document
-  <a href="{{ register_url }}" target="_blank">
+  <a href="{{ serviceUrl }}register" target="_blank">
     create a free account
   </a>
   or <a href="" ng-click="login()">log in</a>