Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove self correlation and default value #457

Closed
wants to merge 1 commit into from

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner March 11, 2024 17:31
Copy link

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 4s ⏱️ -1s
421 tests ±0  421 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 44f600d. ± Comparison against base commit d0e409f.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.50%. Comparing base (d0e409f) to head (44f600d).

Files Patch % Lines
...rawspansgrouper/validator/IpIdentityValidator.java 0.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #457      +/-   ##
============================================
- Coverage     79.59%   79.50%   -0.09%     
  Complexity     1431     1431              
============================================
  Files           130      130              
  Lines          5704     5710       +6     
  Branches        533      539       +6     
============================================
  Hits           4540     4540              
- Misses          912      917       +5     
- Partials        252      253       +1     
Flag Coverage Δ
unit 79.50% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanket-mundra
Copy link
Contributor Author

Couldn't find a better way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant