Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass.override.tenants config to be non quoted #449

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner February 2, 2024 11:31
ravisingal
ravisingal previously approved these changes Feb 2, 2024

This comment has been minimized.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc4d7c0) 79.53% compared to head (e83c244) 79.56%.

❗ Current head e83c244 differs from pull request most recent head bc19213. Consider uploading reports for the commit bc19213 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #449      +/-   ##
============================================
+ Coverage     79.53%   79.56%   +0.03%     
- Complexity     1427     1428       +1     
============================================
  Files           130      130              
  Lines          5692     5692              
  Branches        533      533              
============================================
+ Hits           4527     4529       +2     
+ Misses          912      911       -1     
+ Partials        253      252       -1     
Flag Coverage Δ
unit 79.56% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanket-mundra sanket-mundra enabled auto-merge (squash) February 2, 2024 11:33

This comment has been minimized.

saxenakshitiz
saxenakshitiz previously approved these changes Feb 2, 2024

This comment has been minimized.

This comment has been minimized.

@sanket-mundra sanket-mundra merged commit 4fa3a54 into main Feb 5, 2024
9 checks passed
@sanket-mundra sanket-mundra deleted the sanket/fixConfig branch February 5, 2024 08:55
Copy link

github-actions bot commented Feb 5, 2024

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 10s ⏱️ +3s
420 tests ±0  420 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4fa3a54. ± Comparison against base commit fc4d7c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants