Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request argument to model-api getData method #766

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jake-bassett
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@jake-bassett jake-bassett requested a review from a team as a code owner December 12, 2023 21:01
Copy link

Test Results

    1 files    49 suites   13s ⏱️
296 tests 296 ✔️ 0 💤 0
297 runs  297 ✔️ 0 💤 0

Results for commit aa0554f.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cfa9c3) 100.00% compared to head (aa0554f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #766   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         1452      1452           
  Branches       202       202           
=========================================
  Hits          1452      1452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jake-bassett jake-bassett merged commit 6e5f249 into main Dec 12, 2023
@jake-bassett jake-bassett deleted the model-api-get-data-arg branch December 12, 2023 21:55
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants