Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable view inferences button if user is a windows user #726

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

kristencheung
Copy link
Member

@kristencheung kristencheung commented Jan 24, 2025

Description

show an error if !response.ok
image

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

@kristencheung kristencheung requested a review from a team as a code owner January 24, 2025 21:24
jairad26
jairad26 previously approved these changes Jan 24, 2025
@mattjohnsonpint
Copy link
Member

Per discussion, let's not do a platform test in the component, but rather just check if the api comes back with data using response.ok. Thanks.

@mattjohnsonpint mattjohnsonpint merged commit 2709764 into main Jan 24, 2025
5 checks passed
@mattjohnsonpint mattjohnsonpint deleted the disable-inferences-if-windows branch January 24, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants