Fix CLI hang on Linux #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, it works in GitHub Actions on a Ubuntu runner also. Here's a test run: |
kevinmingtarja
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with CLI hanging on Linux.
The main culprit was the shebang in
cli/bin/modus.js#!/usr/bin/env node --no-warnings=ExperimentalWarningThere were two possible fixes:
#!/usr/bin/env nodeor
#!/usr/bin/env -S node --no-warnings=ExperimentalWarningThe change implemented in #517 removed the need to pass the
--no-warningsflag, so we'll simplify with the first one. (FYI, this was all about getting clean output if the user pressedctrl-cwhile a prompt was open.)Also removed some unused code, and improved the spinner wrapper.