Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade from yaml v2 to v3 everywhere #9279

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

RJKeevil
Copy link
Contributor

@RJKeevil RJKeevil commented Jan 16, 2025

Description

Upgraded gopkg.in/yaml from v2 to v3 in all places. Mostly this is for housekeeping and to bring our fork more in line with main, so that we may remove the fork in near future.

Checklist

  • Code compiles correctly and linting passes locally

@RJKeevil RJKeevil requested a review from a team as a code owner January 16, 2025 09:05
mangalaman93
mangalaman93 previously approved these changes Jan 16, 2025
@mangalaman93
Copy link
Member

@RJKeevil could you rebase on latest main please?

@RJKeevil
Copy link
Contributor Author

RJKeevil commented Jan 27, 2025

@mangalaman93 Done!

@RJKeevil
Copy link
Contributor Author

@mangalaman93 looks like the failure this time was just infra related, probably retriggering the job would work? The self-hosted runner: warp-4x-x64-wvnb41gx4zlj0vkx lost communication with the server.

@RJKeevil
Copy link
Contributor Author

Rebased and pushed again to retrigger the tests, look good now

@mangalaman93 mangalaman93 merged commit 3c27935 into hypermodeinc:main Jan 28, 2025
13 of 14 checks passed
@mangalaman93
Copy link
Member

Thank you for the PR @RJKeevil!

@RJKeevil RJKeevil deleted the yaml.v3 branch January 28, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants