Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade protobuf to version v1.3.5 #5290

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Downgrade protobuf to version v1.3.5 #5290

merged 1 commit into from
Apr 23, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Apr 23, 2020 •
edited by manishrjain
Loading

The protobuf version was updated accidentally in 7b37ddb.
This PR reverts the version update. This should also suppress the warning temporarily .

$ dgraph
2020/04/22 17:19:12 WARNING: proto: file "pb.proto" is already registered
A future release will panic on registration conflicts. See:
https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

This change is Reviewable

@jarifibrahim jarifibrahim requested review from manishrjain and a team as code owners April 23, 2020 21:08
@danielmai danielmai merged commit 38c3640 into master Apr 23, 2020
@danielmai danielmai deleted the ibrahim/protobuf-v1.3.x branch April 23, 2020 22:49
danielmai pushed a commit that referenced this pull request Apr 24, 2020
@danielmai
Downgrade protobuf to version v1.3.5 (#5290)
ec71367
danielmai pushed a commit that referenced this pull request Apr 24, 2020
@danielmai
Downgrade protobuf to version v1.3.5 (#5290)
1b46ac2
danielmai pushed a commit that referenced this pull request Apr 24, 2020
@danielmai
Downgrade protobuf to version v1.3.5 (#5290)
c9cbd13
@mohammed90 mohammed90 mentioned this pull request Jun 27, 2020
Closed
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@dna2github
Downgrade protobuf to version v1.3.5 (hypermodeinc#5290)
f9a6330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarifibrahim @danielmai