Corrected function handling when no language is specified.

[tzdybal]

This is a fix for #1295.

---

This change is 

[manishrjain]

Just make sure that the @. is the tag required for picking any lang.

---

Reviewed 2 of 4 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

wiki/content/query-language/index.md, line 178 at r1 (raw file):

{{% notice "note" %}}In functions, language lists and `.` notation are not allowed.  In functions, a string edge without a language tag means apply function to all languages, while a single language tag means apply to only the given language.{{% /notice %}}

{{% notice "note" %}}In case of full text search functions (`alloftext`, `anyoftext`), when no language is specified default (English) Full Text Search tokenizer is used.{{% /notice %}}

is specified, (comma) default ...

---

Comments from Reviewable

[tzdybal]

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

wiki/content/query-language/index.md, line 178 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

is specified, (comma) default ...

Done.

---

Comments from Reviewable

[pawanrawal]

Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks broke.

---

query/query_test.go, line 6685 at r2 (raw file):

	// this case is not trivial, because farmhash of "en" is less than farmhash of "fr"
	// so we need to iterate over values in all languages to find a match
	// for alloftext, this won't work - we use default/English tokenizer for function parameters,

we use default/English tokenizer when no language is specified.

---

worker/stringfilter.go, line 91 at r2 (raw file):

		}
		return false
	} else {

Can get rid of this else, since you are returning in the if above.
Actually you can handle the smaller len(filter.eqVals) == 0 block first and then the bigger block doesn't need to be indented.

---

worker/task.go, line 502 at r2 (raw file):

	// For string matching functions, check the language.
	if (srcFn.fnType == StandardFn || srcFn.fnType == HasFn ||

This if condition probably needs its own function?

---

worker/task.go, line 664 at r2 (raw file):

					return false
				default:
					langs := []string{arg.srcFn.lang}

What happens when user gives something like name@en:hi:. in functions. Do we give an error or just parse the first language?

---

Comments from Reviewable

[tzdybal]

Review status: 2 of 6 files reviewed at latest revision, 5 unresolved discussions.

---

query/query_test.go, line 6685 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

we use default/English tokenizer when no language is specified.

Done

---

worker/stringfilter.go, line 91 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Can get rid of this else, since you are returning in the if above.
Actually you can handle the smaller len(filter.eqVals) == 0 block first and then the bigger block doesn't need to be indented.

Cyclomatic complexity reduced.

---

worker/task.go, line 502 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

This if condition probably needs its own function?

Good idea. Function introduced.

---

worker/task.go, line 664 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

What happens when user gives something like name@en:hi:. in functions. Do we give an error or just parse the first language?

We return error, it's tested in gql/parser_test.go in TestLangsFunctionMultipleLangs.

---

Comments from Reviewable

[pawanrawal]

---

Reviewed 1 of 4 files at r1, 1 of 4 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[tzdybal]

Merged to master.