feat: OrderExample #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traderben
requested changes
Jan 30, 2025
|
@traderben |
traderben
reviewed
Jan 31, 2025
| const orderWire = orderRequestToOrderWire(orderRequest); | ||
| const orderAction = orderWiresToOrderAction([orderWire]); | ||
|
|
||
| if (!PRIVATE_KEY || PRIVATE_KEY === "0x-your-secret-key") { |
There was a problem hiding this comment.
nit move this to above where you initialize wallet otherwise the example will crash there
| throw new Error("Invalid order type"); | ||
| } | ||
|
|
||
| const orderRequest: OrderRequest = { |
There was a problem hiding this comment.
move this into orderExample. asset should be 0 and remove assetId field. Having two fields for the same thing can lead to inconsistency and confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@traderben
Reflected your feedback. I made an example of placing an order using the existing sign method as it is.