Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch arguments requirements for GetAcceptanceMechanismsRequestOptions in indy-vdr-shared and indy-vdr-react-native/cpp #207

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Mismatch arguments requirements for GetAcceptanceMechanismsRequestOptions in indy-vdr-shared and indy-vdr-react-native/cpp #207

merged 2 commits into from
Aug 10, 2023

Conversation

mrlunin
Copy link

@mrlunin mrlunin commented Aug 10, 2023

Ticket #206

@berendsliedrecht
Copy link
Contributor

Thanks for the fix. Could you sign off your commit so the DCO passes? If that all checks it, I will merge it.

make submitterDid as optional at buildGetAcceptanceMechanismsRequest …
f04ecc6 
…as it defined optional in indy-vdr-shared

Signed-off-by: Alexey Lunin <alexey.lunin@vereign.com>
@mrlunin
Copy link
Author

mrlunin commented Aug 10, 2023

@berendsliedrecht ok, done

@andrewwhitehead andrewwhitehead merged commit 1142b89 into hyperledger:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwhitehead andrewwhitehead andrewwhitehead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrlunin @berendsliedrecht @andrewwhitehead