Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mapping of errors on HTTP responses, and log stacks with debug #96

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

peterbroadhurst
Copy link
Contributor

The use of string parsing could be improved, especially as it doesn't work in cases where the i18n framework is used with custom non-FF prefixes (which we support).

…g level

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #96 (7cdda74) into main (f52df06) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         4943      4967   +24     
=========================================
+ Hits          4943      4967   +24     
Files Changed Coverage Δ
pkg/ffapi/handler.go 100.00% <100.00%> (ø)
pkg/i18n/errors.go 100.00% <100.00%> (ø)

@nguyer nguyer merged commit 8401dd6 into main Sep 11, 2023
@nguyer nguyer deleted the error-casting branch September 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants