Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra HTTP client / retry options #88

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add extra HTTP client / retry options #88

merged 3 commits into from
Jul 17, 2023

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Jul 12, 2023

Have a use case where I need to:

  1. Generate a new piece of data on each retry (a header has to be updated each time)
  2. Do some special checking on status codes etc. to determine if retry is suitable
  3. Limit the number of concurrent HTTP socket connections to a host

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst changed the title Add extra retry options Add extra HTTP client / retry options Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #88 (223178f) into main (da6668c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         4778      4786    +8     
=========================================
+ Hits          4778      4786    +8     
Impacted Files Coverage Δ
pkg/i18n/en_base_config_descriptions.go 100.00% <ø> (ø)
pkg/ffresty/config.go 100.00% <100.00%> (ø)
pkg/ffresty/ffresty.go 100.00% <100.00%> (ø)

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@nguyer nguyer merged commit cea2846 into main Jul 17, 2023
@nguyer nguyer deleted the retry-ext branch July 17, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants