Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs regression in parameter descriptions that changes swagger gen #112

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix docs regression in parameter descriptions that changes swagger gen #112

merged 1 commit into from
Nov 29, 2023

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Nov 29, 2023 •
edited
Loading

We're incorrectly adding a [0] to these messages after #107:

description: 'The maximum number of records to return (max: [0])'
                                                            ^^^

@peterbroadhurst
Fix docs regression in parameter descriptions that changes swagger gen
c603e81 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
nguyer approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@nguyer nguyer merged commit 88b4240 into main Nov 29, 2023
@nguyer nguyer deleted the swagger-braces branch November 29, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyer nguyer nguyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbroadhurst @nguyer