rm unnecessary import dependency from statecouchdb package #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18e4f5b to
1a26e63
Compare
manish-sethi
requested changes
Apr 2, 2020
core/ledger/kvledger/txmgmt/statedb/statecouchdb/statecouchdb_test.go
Outdated
Show resolved
Hide resolved
36c200b to
2dfe4ba
Compare
manish-sethi
previously approved these changes
Apr 6, 2020
The statecouchdb package should not be dependent on too many other packages. It should be self-sufficient. Currently, we have imported ccprovider just for a struct. Further, the test imports ccprovider to use a function. As these are not justified, we remove it. Given that we pass map[string][]byte to the function that processes the index data, we don't need to create a tarFile. Signed-off-by: senthil <cendhu@gmail.com>
2dfe4ba to
1ba7dc6
Compare
|
@manish-sethi fixed conflicts. |
manish-sethi
approved these changes
Apr 7, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The statecouchdb package should not be dependent on too many other packages. It should be self-sufficient. Currently, we have imported ccprovider just for a struct. Further, the test file imports a ccprovider to call a utility function. As these are not justifiable, we remove it and duplicate code as needed.
Additional details
In the ledger refactoring work, we plan to merge the following packages to reduce the folder depth
Due to some unnecessary import dependency, we get import cycles in the refactoring process. Hence, we remove one such unnecessary dependency from the statecouchdb package. In the upcoming PR, we will move structs that are used across packages from
core/ledgertointernal/pkg/ledger. This will also help us reduce the import cycles and do the refactoring without any blockers.Related issues
FAB-17699