Add length check for dirsDepth

[scovetta]

This is a simple addition of a few bounds checks to ensure that the dirsDepth array is not accessed at an index beyond its size.

Type of change

• Improvement (improvement to code, performance, etc)

Description

This change adds index checks before dirDepths[collectionIndexDirDepth] and dirDepths[collectionNameDepth] to avoid indexing beyond the end of the array. We could just check for the collectionIndexDirDepth and avoid the other two, but that would be more brittle in case the constants defined a few lines earlier were reordered. We could also just calculate len(dirsDepth) once as a small perf improvement.

Additional details

I have never used Hyperledger, and did not test this change in any way. I also don't know how likely it would be for dirDepths to short enough to cause the panic.

Related issues

This is related to the suggestion from @manish-sethi in #1080.

[cendhu]

Thank you for your contribution. I have made one comment. Other than that, please address the following too

• Update the unit-test at

  fabric/core/ledger/kvledger/txmgmt/privacyenabledstate/db_test.go

  Line 51 in 89ab0bf

  func TestGetIndexInfo(t *testing.T) {

  to ensure that this case is not missed in the future.
• Need to sign off the PR using git commit --amend -s

[cendhu]

Instead, can you update the first condition in the line 427? len(dirsDepth) > collectionDirDepth to len(dirsDepth) > collectionIndexDirDepth

[sykesm]

@scovetta - It's been a bit since we've heard from you and I'm just wondering if you plan to sign-off on your commit and address Senthil's comments?

Thanks.

[sykesm]

@scovetta We appreciate your time and the effort you've invested in opening this PR. Unfortunately it's been a month since we've heard from you, we're unable to merge commits without a DCO signoff, and there are pending comments so I'm going to close this out. If you find that you have some time to to revisit this in the future, please feel free to reopen.

Thanks.