Throttle session creation in nwo.Network #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many places in the integration tests where the network will repeatedly poll for some condition using Fabric command line tools in an `Eventually`. When this pattern is used, the commands are executed every 10ms until until the polling expires or the condition is satisfied. While this works, the polling does not have to be run as frequently. This change introduces a `SessionCreateInterval` field to the network that can be used to influence how quickly the same command can be re-issued. The default value of 1s will reduce the frequency of CLI execution when used in an Eventually loop without impacting the polling on sessions or other activities. Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
a42ae32 to
047814c
Compare
yacovm
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places in the integration tests where the network will repeatedly poll for some condition using Fabric command line tools in an
Eventually. When this pattern is used, the commands are executed every 10ms until until the polling expires or the condition issatisfied. While this works, the polling does not have to be run as frequently.
This change introduces a
SessionCreateIntervalfield to the network that can be used to influence how quickly the same command can be re-issued. The default value of 1s will reduce the frequency of CLI execution when used in an Eventually loop without impacting the polling on sessions or other activities.