[FAB-17732] HSM clarifications #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc3faa6 to
49dc7df
Compare
caod123
reviewed
Apr 15, 2020
ashku
reviewed
Apr 15, 2020
There was a problem hiding this comment.
@pamandrejko , some comments. These comments are applicable to all HSM docs. Please make change everywhere.
denyeart
reviewed
Apr 15, 2020
denyeart
previously approved these changes
Apr 16, 2020
nikhil550
reviewed
Apr 16, 2020
Signed-off-by: pama-ibm <pama@ibm.com>
caod123
approved these changes
Apr 16, 2020
|
LGTM |
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pama-ibm pama@ibm.com
Addressed Dave's leftover feedback from PR #1027:
Added
Immutable : falseto the BCCSP parameters.Type of change
Description
Original updates were made to the release-1.4 branch to support AWS HSM via the BCCSP
AltIdfield.AltIDis not supported yet in the master branch. When it is we will need to add it.In the meantime, I addressed Dave's other comments that we will need to cherry-pick back to release-1.4 when after this is merged.
Related issues
FAB-17732