Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17740] Update configtx package documentation #1096

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

stephyee
Copy link
Contributor

Type of change

  • Documentation update

Description

Add additional information about the configtx package in the godoc overview

Related issues

FAB-17740

@stephyee stephyee requested a review from a team as a code owner April 15, 2020 12:04
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@wlahti
Copy link
Contributor

wlahti commented Apr 15, 2020

Nit: the lines are really long, which makes it a little annoying to review. :) Any reason to not follow the general standard of <80 characters per line?

@stephyee
Copy link
Contributor Author

@wlahti Not really, I didn't think about it much given its docs and not code. I can shorten them.

Copy link

@caod123 caod123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention something specific about system channel genesis block? Not sure if it's super necessary though.

pkg/configtx/config.go Outdated Show resolved Hide resolved
Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
@caod123 caod123 merged commit d18938a into hyperledger:master Apr 17, 2020
@stephyee stephyee deleted the fab-17740 branch April 17, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants