[LEDGER] remove TxMgr interface #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the validator, we already create a mock for TxMgr interface but use the mock created at txmgr package. Hence, we make the validator to use the mock that present locally. Further, the validator does not need to create mock for all APIs in the TxMgr interface as it only uses NewTxSimulator(). Hence, we define a local interface. Signed-off-by: senthil <cendhu@gmail.com>
We have a TxMgr interface as the initial plan was to implement two types of transaction manager: (1) lock based txmgr (2) snapshot isolation based txmgr In the last three years and in the many coming years, we may not implement another txmgr. Hence, we can remove the interface. Signed-off-by: senthil <cendhu@gmail.com>
This was referenced Apr 15, 2020
|
We will reopen this once we finish refactoring the mvcc validator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
We have a TxMgr interface as the initial plan was to implement two types of transaction manager:
In the last three years and in the many coming years, we may not implement another
TxMgr. Hence, we remove the interface.Additional details
As we decided to keep a single TxMgr implementation, we can avoid additional folder depth and reduce a package by moving
lockbasedtxmgrtotxmgr.TxStatInfodefined intxmgris imported in bothlockbasedtxmgrandvalidator. If we move thelockbasedtxmgrtotxmgr, we will get an import cycle. AsTxStatInfois used bykvledger,metrics,lockbasedtxmgr, andvalidator, we need to find a suitable place to keep these structs. Only if we can do that, we can movelockbasedtxmgrtotxmgr-- FAB-17757Merge this only after merging #1094
Related issues
FAB-17756