Extend SigningIdentity with config update signing functions #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAB-17741 Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
caod123
approved these changes
Apr 15, 2020
| @@ -76,3 +82,145 @@ func toLowS(key ecdsa.PublicKey, sig ecdsaSignature) ecdsaSignature { | |||
|
|
|||
| return sig | |||
| } | |||
|
|
|||
| // SignConfigUpdate signs the given configuration update with a | |||
There was a problem hiding this comment.
nit: can probably reword this now since there isnt a "specified" signing identity passed in anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Move and rename config update signing functions.
Related issues
FAB-17741