[FAB-17709] Support creating system channel genesis block #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caod123
suggested changes
Apr 14, 2020
pkg/config/config.go
Outdated
|
|
||
| block, err := newSystemChannelBlock(ct, channelID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("creating system channel block: %v", err) |
There was a problem hiding this comment.
likewise to my comment on the function name, I think this error will need some rework too. We probably want to focus more on the fact that this is the genesis block as otherwise creating system channel block can be misconstrued for what this function is intended to be used for.
There was a problem hiding this comment.
I also added "genesis" in the error.
C0rWin
reviewed
Apr 16, 2020
C0rWin
reviewed
Apr 16, 2020
pkg/config/config.go
Outdated
|
|
||
| block := newBlock(0, nil) | ||
| block.Data = &cb.BlockData{Data: [][]byte{blockData}} | ||
| block.Header.DataHash = blockDataHash(block.Data) |
There was a problem hiding this comment.
IMO it might make sense to encapsulate this initialization within newBlock
Add a function to create a system channel genesis block. Remove Consortium for system channel in function newSystemChannelGroup. Set channelGroup.ModPolicy to be Admins in function newChannelGroup and newSystemChannelGroup. Signed-off-by: xu wu <wuxu1103@163.com>
C0rWin
approved these changes
Apr 16, 2020
caod123
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function to create a system channel genesis block.
Signed-off-by: xu wu wuxu1103@163.com
Type of change
Description
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17709