mv rangequery option validation to ledger/internal

The range query receives metadata such as pagination limit.
ValidateRangeMetadata() validates the received metadata. As
the ValidateRangeMetadata() is present in statedb, it is imported
in both statecouchdb and stateleveldb packages. As we want these
packages to be self-sufficient and only import ledger/internal
packages, we move the ValidateRangeMetadata() to
ledger/interal/rangequery.

Further, the term metadata is confusing with the statemetadata
which stores the key-based endorsement. Hence, we replace
Metadata in range query API with options.

Signed-off-by: senthil <cendhu@gmail.com>

core/chaincode/handler.go

@@ -743,7 +743,7 @@ func (h *Handler) HandleGetStateByRange(msg *pb.ChaincodeMessage, txContext *Tra
 				startKey = metadata.Bookmark
 			}
 		}
-		rangeIter, err = txContext.TXSimulator.GetStateRangeScanIteratorWithMetadata(namespaceID,
+		rangeIter, err = txContext.TXSimulator.GetStateRangeScanIteratorWithOptions(namespaceID,
 			startKey, getStateByRange.EndKey, paginationInfo)
 	} else {
 		rangeIter, err = txContext.TXSimulator.GetStateRangeScanIterator(namespaceID, getStateByRange.StartKey, getStateByRange.EndKey)

core/committer/txvalidator/v14/validator_test.go

@@ -1552,8 +1552,8 @@ func (exec *mockQueryExecutor) GetStateRangeScanIterator(namespace string, start
 	return args.Get(0).(ledger2.ResultsIterator), args.Error(1)
 }
 
-func (exec *mockQueryExecutor) GetStateRangeScanIteratorWithMetadata(namespace, startKey, endKey string, metadata map[string]interface{}) (ledger.QueryResultsIterator, error) {
-	args := exec.Called(namespace, startKey, endKey, metadata)
+func (exec *mockQueryExecutor) GetStateRangeScanIteratorWithOptions(namespace, startKey, endKey string, options map[string]interface{}) (ledger.QueryResultsIterator, error) {
+	args := exec.Called(namespace, startKey, endKey, options)
 	return args.Get(0).(ledger.QueryResultsIterator), args.Error(1)
 }