update CODEOWNERS #263
Merged
update CODEOWNERS #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvavala
approved these changes
Mar 17, 2020
Signed-off-by: Michael Steiner <michael.steiner@intel.com>
Signed-off-by: Michael Steiner <michael.steiner@intel.com>
1ac148a to
1f5c106
Compare
bvavala
pushed a commit
that referenced
this pull request
May 7, 2020
…run demo (#339) * Update rocket chat We got our own rocket chat channel! Please join us at Signed-off-by: bur <bur@zurich.ibm.com> * fix environment Signed-off-by: lengyijun <sjtu5140809011@gmail.com> * fix README.md Signed-off-by: lengyijun <sjtu5140809011@gmail.com> * Bump acorn from 6.4.0 to 6.4.1 in /demo/client/frontend Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> * Bump node deps Update node deps in demo frontend/backend and docker utils Signed-off-by: bur <bur@zurich.ibm.com> * update CODEOWNERS (#263) * update list Signed-off-by: Michael Steiner <michael.steiner@intel.com> * fixup! update list Signed-off-by: Michael Steiner <michael.steiner@intel.com> * disclaimer and explicit list of "official" releases Signed-off-by: Michael Steiner <michael.steiner@intel.com> * make avatar download a bit more robust and graceful Signed-off-by: Michael Steiner <michael.steiner@intel.com> * Docker dev run mounts FPC from local fs This mounts the local FPC repository by default into a dev container when `make run` is called. Before this was optional but turned out that it should be the default. Signed-off-by: bur <bur@zurich.ibm.com> * Fix build for concept-release - move both dev and peer to build from local HEAD commit - (try to) minimize re-build of images - add missing dependencies to dev container Signed-off-by: michael steiner <michael.steiner@intel.com> * Version docker images Signed-off-by: michael steiner <michael.steiner@intel.com> * Make FABRIC_VERSION arg/env in dockerfile consistent with vars used to get docker tag Signed-off-by: michael steiner <michael.steiner@intel.com> * More robust and precise handling of docker image cleanup Signed-off-by: michael steiner <michael.steiner@intel.com> * A more robust teardown Signed-off-by: Michael Steiner <michael.steiner@intel.com> * Make missing device error more explicit and make SGX_MODE=SIM default for build - note this is already done for a number of scripts and makes it more fail-safe from usage-perspective (though not from security :-). Also note that cmake still has a HW default but that will be removed and referring to the config.mk default in a separate PR) Signed-off-by: michael steiner <michael.steiner@intel.com> * Fix path so we can call make also via `make -C utils/docker run` Signed-off-by: michael steiner <michael.steiner@intel.com> * Make rm failure abort make (Note rm -f does _not_ file if the files do not exist ..) Signed-off-by: michael steiner <michael.steiner@intel.com> * Make docker-based tests run also inside dev(elopment) container * make sure host network is also available inside * for volume mounts, make sure the source path maps to a path understood by docker daemon Signed-off-by: michael steiner <michael.steiner@intel.com> * Build/Test only via dev container and not also directly on host Signed-off-by: michael steiner <michael.steiner@intel.com> Co-authored-by: bur <bur@zurich.ibm.com> Co-authored-by: lyj <sjtu5140809011@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.