Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fix, propagate release name preprocessing #7599

Merged

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Sep 10, 2024

PR description

Fixed Issue(s)

Fixes pre-processed release name propagation in the release workflow jobs via a dedicated preprocessing job.

Post-24.8.0 release, preprocessing of release names was added to ensure they are well formed. The envar method of propagation is limited to a single job however. Subsequent release workflow jobs do not have this value and are failing.

This PR:

  • moves release name preprocessing to its own job
  • makes release_name a job output
  • for each job that require an explicit release version:
    • adds a dependency on pre_process_release_name
    • declares an envar RELEASE_NAME from the output of the preprocess_release_name job

Verified on a fork that release name is propagated to the dependent jobs:

  • artifacts
  • buildDocker
  • artifactoryPublish
  • multiArch
  • amendNotes
  • dockerPromoteX64
  • verifyContainer

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte changed the title CI Fix, propagate release name preprocessing via job output CI Fix, propagate release name preprocessing Sep 10, 2024
@garyschulte garyschulte requested a review from siladu September 10, 2024 22:21
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. The variable context scope is such a common error...seems to happen almost every time we touch these workflows 😓

runs-on: ubuntu-22.04
steps:
- name: Pre-process Release Name
id: pre_process_release_name
Copy link
Contributor

@siladu siladu Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: preprocess vs pre_process

...only because it feels ripe for a future bug in this case! Both variants are used in this job and referenced by other jobs

@garyschulte garyschulte enabled auto-merge (squash) September 11, 2024 01:32
@garyschulte garyschulte merged commit 6ea0ed4 into hyperledger:main Sep 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants